1

Closed

ContextMenu String Resources are missing

description

String resources in context menu seem to be missing (see screenshot). The sub-menu entries for Selection and View are also looking strange like this.

file attachments

Closed Jun 12, 2014 at 7:01 AM by lycj

comments

dirkster wrote May 14, 2014 at 8:18 PM

-

lycj wrote May 16, 2014 at 8:50 AM

Caused by not focused in explorer when it first started.

Fixed by setting CommandTarget of ContextMenuItem.

<Style x:Key="CommandModelContextMenuMenuItemStyle" TargetType="MenuItem" BasedOn="{StaticResource {x:Type MenuItem}}">
...
    <Setter Property="CommandTarget" Value="{Binding Path=PlacementTarget,
    RelativeSource={RelativeSource
        AncestorType=ContextMenu}}" />
... />

lycj wrote May 16, 2014 at 9:23 AM

** Closed by lycj 05/16/2014 2:23AM

dirkster wrote May 19, 2014 at 6:04 PM

I downloaded the current build (change set 403c23dd1482) and was still able to see the incomplete context menu. Are you sure this problem is really fixed?

lycj wrote May 20, 2014 at 9:36 AM

Yes, I found I fixed the DirectoryTree one, but not the FileList one.

lycj wrote May 27, 2014 at 9:25 AM

The FileList problem is caused by ICommandModel.IsVisibleOnMenu is set to default true to default false, and I missed updating sub-items.

Similar issue for FileList Toolbar's Open button, just fixed today.

In ExCommandProvider:
    public List<ICommandModel> GetCommandModels()
    {
        return new List<ICommandModel>()
                {                        
                    new OpenWithCommandEx(_profile) { IsVisibleOnToolbar = false } //should be true
                };
    }